Fix/pglite socket ssl request#990
Merged
tdrz merged 5 commits intoJun 15, 2026
Merged
Conversation
tdrz
requested changes
Jun 13, 2026
bookernath
pushed a commit
to bookernath/pglite
that referenced
this pull request
Jun 21, 2026
Rebased onto main, which now handles SSLRequest (replies 'N') via the extracted handleSslRequest() method (electric-sql#990). Adapts the remaining CancelRequest handling to that same style as requested in review: adds named CANCEL_REQUEST_CODE / CANCEL_REQUEST_LENGTH constants (no magic numbers) and extracts the logic into a dedicated handleCancelRequest() method called from the handleData() loop alongside handleSslRequest(). PGlite has no backend process to signal, so the request is consumed and silently ignored (the protocol expects no response). Drops the now-redundant inline SSL handling and SSL-specific tests (covered by upstream's ssl-request.test.ts); keeps a CancelRequest integration test.
2 tasks
bookernath
pushed a commit
to bookernath/pglite
that referenced
this pull request
Jun 25, 2026
Rebased onto main, which now handles SSLRequest (replies 'N') via the extracted handleSslRequest() method (electric-sql#990). Adapts the remaining CancelRequest handling to that same style as requested in review: adds named CANCEL_REQUEST_CODE / CANCEL_REQUEST_LENGTH constants (no magic numbers) and extracts the logic into a dedicated handleCancelRequest() method called from the handleData() loop alongside handleSslRequest(). PGlite has no backend process to signal, so the request is consumed and silently ignored (the protocol expects no response). Drops the now-redundant inline SSL handling and SSL-specific tests (covered by upstream's ssl-request.test.ts); keeps a CancelRequest integration test.
tdrz
pushed a commit
that referenced
this pull request
Jun 25, 2026
Rebased onto main, which now handles SSLRequest (replies 'N') via the extracted handleSslRequest() method (#990). Adapts the remaining CancelRequest handling to that same style as requested in review: adds named CANCEL_REQUEST_CODE / CANCEL_REQUEST_LENGTH constants (no magic numbers) and extracts the logic into a dedicated handleCancelRequest() method called from the handleData() loop alongside handleSslRequest(). PGlite has no backend process to signal, so the request is consumed and silently ignored (the protocol expects no response). Drops the now-redundant inline SSL handling and SSL-specific tests (covered by upstream's ssl-request.test.ts); keeps a CancelRequest integration test. Co-authored-by: bookernath <nathan.booker@bigcommerce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#989
Handle the
SSLRequeststartup packet per the PostgreSQL wire protocol: when SSL is not available, respond withNso the client may continue with a cleartextStartupMessage. Improves interoperability with JDBC clients such as DBeaver that probe TLS first without requiring manual SSL mode tweaks. See https://www.postgresql.org/docs/current/protocol-message-formats.html .